correct Japanese structure is こんばんは、先生、お元気ですか？but most of time people omit subject, so こんばんは、お元気ですか？ is fine too :)

お元気ですか先生 since it's for the teacher, this makes it a little formal. if you have a very close relationship, you can say 元気ですか。