"For ever"means that implies that something is "the duration of ever." While the etymology(word origin) of forever is probably "for ever", "forever" is always the proper word to use. Forever Adverb For all future time; for always. A very long time (used hyperbolically).

You should always use "forever", meaning eternally or continually.