For the nationality one, both are equally good. "Are you married?" is much more common than "What's your marital status?", which is really only used on job applications and things like that. Both are good. "What do you do (for a living)?" is less formal than "What's your profession?" "How long have you worked at this job?" OR "How long have you been working at this job?"