The tense is correct (unless the person is still studying at school). You can also say: How many years did you go to school for? or For how long did you study at school?