Hello Fahridden, Both are fine. However, "Brother forever" is more common and natural. Example sentences for both - "You are my brother forever" or "you will forever be my brother" both can be used. I hope this helps you.

There's an abbreviation BFF, means "best friend forever". I think, you can use it with the word " brother" as well.