This sentence isn't quite correct, but I would need more context to be able to correct it. If you are thanking a teacher who has taught a group of children, you would write something like: "Thank you for your great efforts in providing children's music education." If you are thanking people who donated or otherwise supported children's education, you would write something like: "Thank you for your great efforts in supporting children's music education." If you have anymore questions, I would love to help. :)

If you mean giving thanks to a teacher who is teaching the children music, we will correct it : Thank you for your great efforts on crafting my children in music