We have been friends forever

Ok, this really depend on what do you want to say. Every sentence has its own time frame. "tense" If you still are friends then use "we are friends forever" If were friends and no more, then use " we have been friends forever" this indicates that you were friends but not anymore.

Both can be correct. Different tenses. Different meanings.