Teacher of Spanish or Spanish teacher? are they both ok? What's the most appropriate?

Question

Answer

One may use both. "Spanish teacher" is the informal usage. "Teacher of Spanish is more of a title.

Answer

1. Teacher of Spanish. = He or she teaches Spanish.

2. Mr. Smith is a SPANISH teacher. (He teaches Spanish.) [Stress -- say strongly -- the word "Spanish.']

3. Mr. Smith is a Spanish TEACHER. (He is a Spanish person. Maybe he teaches science.) [Stress "teacher."]