Through 8 years of learning French I can say it really depends. If your French is just basic, flash cards and vocab practice are usually the way forward. However, if your French is advanced to the point where you can read, say, news articles or whatever, then reading those and looking up the vocab you don't understand is a much better move. You learn how words fit in in context, and they stick in your head without you even noticing.

As a teacher I have seen many students miss out on the correct pronunciation of words due to using the flash card method. Combine it with phonetics.

Oh ok. So, I think you can keep it but certainly it's difficult for you to use and it's better to use more lessons for learn the language, which make you call words without the impression to work. Also, I recommend to you to read in French in priority, like the book Folio in bi language that you can find easily with a request on an engine search...

les fiches memoires

What do you mean by 'flash cards', please ?